Skip to content

Fix mailbox cli argument parsing and improve documentation #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

schaerl
Copy link
Contributor

@schaerl schaerl commented Apr 10, 2025

This PR fixes #1694. I am not really versed in C#, but I thought I provide what I hope to be the fix, since I was looking into the code anyways, to figure out how to add the mailboxes on startup without having to add a custom file.

Sorry for not adding any tests, but as I said, I don't have any experience with C#. Feel free to add and adjust as you feel appropriate.

  • Adds the data passed to mailbox= to the Mailboxes
  • Changes the error message for the TypeConverter for MailboxSettings and UserSettings
  • Adds a hint on how to add mailboxes via EnvironmentVariable (which already worked, but since it's a bit of a more complicated case deserves an example, IMO)

Lukas Schär added 3 commits April 10, 2025 19:28
The error states to use the format with a colon, however, the transformation is
actually done with a equal sign, and that's also what the CLI states to use.
@rnwood rnwood merged commit 4c49c7d into rnwood:master Apr 11, 2025
16 checks passed
@rnwood
Copy link
Owner

rnwood commented Apr 11, 2025

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --mailbox command line argument adds the input to the Users, not the mailboxes
2 participants