Fixed external phase delay issue described in … #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready for merge! There is more exploration needed to completely remove the error between using an external input sampled from sin(t) and the original forcing function, sin(t). The C-based integrators seem to be correct, and so is VODE when sin(t) is used directly, so there's something wrong with the computation of input values on time steps for the VODE Generator. Euler should also be checked. Then, the regression tests for external inputs will need adjusting (currently failing in CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VODE was looking ahead by one time sample when preparing next time step's external inputs for use in the RHS function. This partly fixes the primary issue described here:
https://sourceforge.net/p/pydstool/discussion/472291/thread/e55d28a2/