Skip to content

ForkedJarlungoodoo73 patch 1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jarlungoodoo73 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ForkedJarlungoodoo73 patch 1 #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85b9196
Add Docker Image CI workflow
jarlungoodoo73 Jan 1, 2026
4eb3aad
Merge pull request #1 from jarlungoodoo73/jarlungoodoo73-patch-1
jarlungoodoo73 Jan 1, 2026
8ed95eb
Merge pull request #1 from jabidahscreationssystems-com/main
jarlungoodoo73 Jan 1, 2026
829c857
Merge pull request #1 from Jabidahs-Creations-Systems/main
jarlungoodoo73 Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/jekyll-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Jekyll site CI

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
Comment on lines +3 to +7
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is configured to trigger on push and pull_request events to the main branch, which overlaps with the existing deploy.yml workflow that also triggers on pushes to main. This duplication could lead to unnecessary CI runs, wasted resources, and potential conflicts. Since this repository uses React/Node.js (not Jekyll), this workflow should likely be removed entirely, or if both are needed, their trigger conditions should be differentiated.

Copilot uses AI. Check for mistakes.

Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow lacks a permissions declaration. GitHub Actions workflows should explicitly define the permissions they require following the principle of least privilege. The existing deploy.yml workflow in this repository includes a permissions block. Consider adding a permissions section to specify exactly what access this job needs, or use 'permissions: {}' if no special permissions are required beyond the default read-only access.

Suggested change
permissions:
contents: read

Copilot uses AI. Check for mistakes.
jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Build the site in the jekyll/builder container
run: |
docker run \
-v ${{ github.workspace }}:/srv/jekyll -v ${{ github.workspace }}/_site:/srv/jekyll/_site \
jekyll/builder:latest /bin/bash -c "chmod -R 777 /srv/jekyll && jekyll build --future"
Comment on lines +19 to +20
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using chmod -R 777 is a significant security risk as it grants read, write, and execute permissions to all users on all files and directories. This overly permissive approach can lead to security vulnerabilities. Instead, consider using more restrictive permissions or running the container with appropriate user permissions using the --user flag in docker run.

Suggested change
-v ${{ github.workspace }}:/srv/jekyll -v ${{ github.workspace }}/_site:/srv/jekyll/_site \
jekyll/builder:latest /bin/bash -c "chmod -R 777 /srv/jekyll && jekyll build --future"
--user $(id -u):$(id -g) \
-v ${{ github.workspace }}:/srv/jekyll -v ${{ github.workspace }}/_site:/srv/jekyll/_site \
jekyll/builder:latest jekyll build --future

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +20
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Jekyll workflow appears to be incompatible with the repository's technology stack. The repository is a React-based portfolio application (as evidenced by package.json, the existing deploy.yml workflow, and the React source files), not a Jekyll site. Adding a Jekyll-based CI workflow would not function correctly for this project and conflicts with the existing Node.js/React deployment workflow in deploy.yml.

Copilot uses AI. Check for mistakes.