Corrected Slot Time Entities in HA (Issue: #190)#205
Closed
criticallimit wants to merge 2 commits into
Closed
Conversation
criticallimit
commented
Jun 27, 2026
Contributor
Contributor
|
@criticallimit You probably have to change assert val == 1330 in function test_parse_time_hhmm of /tests/model/test_models.py for the check to succeed: FAILED tests/model/test_models.py::TestGrowattRegisters::test_parse_time_hhmm - AssertionError: assert '13:30' == 1330 |
Contributor
Author
|
yes, I´v already seen that too. But that are only test files from Robert and should have no influence to GroBro. Maybe Robert can have a look.... |
Contributor
Author
|
closed due to waiting for actual version from Robert and only apply necessary changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.