Skip to content

Corrected Slot Time Entities in HA (Issue: #190)#205

Closed
criticallimit wants to merge 2 commits into
robertzaage:mainfrom
criticallimit:main
Closed

Corrected Slot Time Entities in HA (Issue: #190)#205
criticallimit wants to merge 2 commits into
robertzaage:mainfrom
criticallimit:main

Conversation

@criticallimit

Copy link
Copy Markdown
Contributor
614149125-60748d57-2b91-4376-b6df-1198dfe26b7c

@super-sonic-zero

Copy link
Copy Markdown
Contributor

@criticallimit You probably have to change assert val == 1330 in function test_parse_time_hhmm of /tests/model/test_models.py for the check to succeed:

FAILED tests/model/test_models.py::TestGrowattRegisters::test_parse_time_hhmm - AssertionError: assert '13:30' == 1330

@criticallimit

Copy link
Copy Markdown
Contributor Author

yes, I´v already seen that too. But that are only test files from Robert and should have no influence to GroBro.

Maybe Robert can have a look....

@criticallimit

Copy link
Copy Markdown
Contributor Author

closed due to waiting for actual version from Robert and only apply necessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants