Skip to content

Offset corrected FW-Parts for NOAH#210

Merged
robertzaage merged 1 commit into
robertzaage:mainfrom
criticallimit:main
Jun 30, 2026
Merged

Offset corrected FW-Parts for NOAH#210
robertzaage merged 1 commit into
robertzaage:mainfrom
criticallimit:main

Conversation

@criticallimit

Copy link
Copy Markdown
Contributor

before:
Screenshot 2026-06-30 074656

corrected:
Screenshot 2026-06-30 080237

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@criticallimit

criticallimit commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@super-sonic-zero
Sorry for confirming correct Offset before in your PR. Guess that I missed to update my Fork with your PR and so it was shown correctly on my side.
But now we know that Noah is using Reg 119 as 00 11 and Reg 120 as 22 33 (double numbers reflect FW-Parts)

@robertzaage robertzaage merged commit 66a9750 into robertzaage:main Jun 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants