perf: reduce scrolling update overhead - #1111
Open
davidarny wants to merge 3 commits into
Open
Conversation
davidarny
force-pushed
the
codex/fix-scroll-frame-rate
branch
from
August 14, 2026 06:22
a9d6c9d to
be89eea
Compare
davidarny
marked this pull request as ready for review
August 15, 2026 04:07
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Collaborator
Author
|
@robinebers @validatedev so you can check this build vs main branch. scrolling should be better in terms of FPS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Reduces avoidable SwiftUI and SVG work while the dashboard scrolls. Keeps reference-backed reorder geometry and cached provider SVG paths, while restoring row-local reorder gestures instead of attaching one simultaneous drag gesture to the whole dashboard.
This PR remains draft. The Instruments results are directional hitch measurements, not an exact FPS claim.
What was happening
What this changes
Heads-up
Tests
swift test --filter ReorderGeometryTests— 3 tests passed, 0 failures.swift test— 1,289 tests passed, 3 skipped, 0 failures; the Swift Testing run also passed 3 tests../script/build_and_run.sh build— release bundle built successfully (using the repository's prebuilt icon fallback and ad-hoc signing in this environment).