Claude accounts 14: keep account identifiers out of analytics - #1157
Closed
robinebers wants to merge 1 commit into
Closed
Claude accounts 14: keep account identifiers out of analytics#1157robinebers wants to merge 1 commit into
robinebers wants to merge 1 commit into
Conversation
Owner
Author
|
Consolidated into #1147 so the multi-account implementation remains reviewable as four cohesive PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Prevent account-specific card identifiers from being saved or transmitted in OpenUsage analytics.
What was happening
What this changes
Tests
Note
Medium Risk
Touches analytics persistence and event payloads (privacy-sensitive data handling). The change is a narrowing of identifiers, not new collection, but mistakes here could leak account hashes or merge counters incorrectly.
Overview
Stops multi-account card hashes from being stored or sent in OpenUsage analytics. Provider and metric IDs are now reduced to their provider family (
ProviderAccountID.family) before counters persist and beforeapp_daily_active/provider_refresh_dailyevents fire.Account-specific entries in the daily config snapshot are also deduped onto family IDs, so multiple Claude/Codex cards collapse to one family. Tests cover that hashes never appear in events or persisted counter keys, and that account refreshes share a single family rollup.
Reviewed by Cursor Bugbot for commit 556e4c5. Bugbot is set up for automated code reviews on this repo. Configure here.