Remove deprecated RPA.Desktop.Windows, fix locator parsing and Highlight Elements - #1343
Merged
Merged
Conversation
…d Highlight Elements BREAKING CHANGE: RPA.Desktop.Windows (pywinauto-based) is removed. It has been deprecated for a long time in favor of RPA.Windows, which superseded it. Also fixes rpaframework-core's Windows locator tokenizer silently mis-parsing a strategy when a stray `locator=` prefix or unmatched quote leaks into the value (e.g. `locator='executable:...`), and makes RPA.Desktop's Highlight Elements return the element regions it already computes instead of discarding them. Fixes #1322, #1323, #1324. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 18, 2026
# Conflicts: # docs/source/releasenotes.rst # packages/main/uv.lock
Wheel artifactBuilt from commit Artifact name: |
- install_local no longer adds the current package as its own editable dependency, and exits early when there's nothing else to link. - get_package_paths now reads the package name from PEP 621 [project] tables in addition to legacy [tool.poetry] ones. - Run uv add non-interactively (in_stream=False). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Windows file names are case-insensitive, but _get_control_from_listed_windows compared them with `==`. So `executable:notepad.exe` could not find a process that Windows lists as `Notepad.exe`, which is what Windows 11 does — making the documented `executable:` strategy unusable there. Fold the comparison for `executable` only. `handle` is numeric and keeps exact matching. Found while verifying the #1323 fix against a real Windows 11 desktop: the `executable:notepad.exe` locator from the issue could not resolve at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R5fd658SbZtHYC6nGpE1H5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RPA.Desktop.Windows(pywinauto-based) library — it has emitted a deprecation warning pointing atRPA.Windowsfor a long time and is unmaintained.rpaframeworkbumped to33.0.0.rpaframework-core's Windows locator tokenizer silently mis-parsing a strategy when a straylocator=prefix or unmatched quote leaks into the locator value (e.g.locator='executable:AsdfConfigurator.exe), instead of recognizing theexecutable:strategy.rpaframework-corebumped to13.0.2.RPA.Desktop'sHighlight Elementsnow returns the list of matched element regions instead of discarding them.examples/scripts that depended exclusively on the removed pywinauto API, since noRPA.Windowsport could be verified without a Windows environment.Fixes #1322, #1323, #1324.
Test plan
uv run pytest tests/python/— 626 passed (packages/main)uv run pytest tests/python/— 144 passed, including 2 new locator-tokenizer cases (packages/core)Highlight Elementsreturn value (packages/main)uv run pylintclean on both packagesRPA.Windowslocator parsing andHighlight Elementson a Windows machine before release🤖 Generated with Claude Code