Require rpaframework-core >=13.0.2 - #1349
Closed
mikahanninen wants to merge 1 commit into
Closed
Conversation
The floor was still >=13.0.0, so a fresh install of rpaframework 33.0.0 could resolve an older core that lacks the Windows locator fixes RPA.Windows depends on — the stray `locator=` prefix handling and case-insensitive `executable:` matching, both shipped in core 13.0.2. Not academic: `uv lock` was resolving rpaframework-core 13.0.0 before this change and 13.0.2 after. Bumps rpaframework to 33.0.1, since 33.0.0 is already published and its metadata cannot be changed in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R5fd658SbZtHYC6nGpE1H5
Wheel artifactBuilt from commit Artifact name: |
Collaborator
Author
|
Superseded by the security batch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpaframework33.0.0 shipped withrpaframework-core>=13.0.0, so a fresh install could resolve a core that predates the Windows locator fixesRPA.Windowsrelies on — the straylocator=prefix handling (#1323) and case-insensitiveexecutable:matching, both released in core 13.0.2.This is not theoretical:
uv lockresolvedrpaframework-core 13.0.0before this change and13.0.2after.Bumps
rpaframeworkto 33.0.1, since 33.0.0 is already on PyPI and its metadata cannot be amended.Note for reviewers
packages/windowsis the package that actually imports the fixed code (from RPA.core.windows.locators import ...) and it still pinsrpaframework-core >=13.0.0. Bumping it would mean releasingrpaframework-windowstoo, so it is left out of this PR — worth a follow-up decision.Test plan
uv run pytest tests/python/— 626 passed (packages/main)uv lockresolves core 13.0.2🤖 Generated with Claude Code
https://claude.ai/code/session_01R5fd658SbZtHYC6nGpE1H5