Skip to content

highlight 'per-class' in confidence mode descriptions - #2998

Open
leeclemnet wants to merge 1 commit into
mainfrom
fix/best-confidence-explicit-about-per-class
Open

leeclemnet wants to merge 1 commit into
mainfrom
fix/best-confidence-explicit-about-per-class

Conversation

@leeclemnet

@leeclemnet leeclemnet commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

For model blocks supporting "Best" confidence mode, explicitly mention per-class confidence in the description. This is to address field eng feedback that the per-class nature of this mode was not obvious.

I did not add "Per Class" to the parameter name in the dropdown because it was too wide for the available space and was cut off.

Type of Change

  • Other: workflow block description edit

Testing

  • I have tested this change locally
  • I have added/updated tests for this change no test update needed

Test details:

  • local staging server build
image image image image

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely.

🚦 This PR is marked Ready for review, so automated Claude review will run — and every pass spends real credits.

Warning

💸 The Claude reviewer bills in credits, not vibes

Automated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared.

Draft when unsure, Ready when you mean it:

  • 🌱 Not sure the PR is in good shape yet? Keep it (or set it back) as a draft — drafts pause review, so you can push and iterate without burning credits on a moving target.
  • 💪 Feel strong about the contents? Mark it Ready for review and the reviewer will take a look.

However you get there, arrive prepared:

  • 🧱 Bring a SOLID, thorough PR. Point your local agent at our skills/ to tune it to our guidelines first — or, if you are one of those fabled carbon-based contributors, read them yourself. A half-baked diff costs exactly the same to review as a finished one.
  • Resolve every comment before you re-request review. Re-requesting with threads still open means paying twice for the same conversation.
  • 🔁 Do not use CI review as an inner loop for a local agent. The reviewer is not a step-by-step debugger — do the unfolding locally and arrive with the answer, not the search.
  • 🙋 If something looks off, ask a human. One question to a maintainer is cheaper and faster than three rounds of agent re-review chasing a misread.

Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.

  • Prefer to skip automated review entirely? Add the skip-claude-review label.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Claude review started at commit b3b53fbcc75ebeb8da3c8b2028b890be68fc648a.

New commits are not auto-reviewed. Add the claude-review label to request a re-review — the label is consumed when the review starts, so just add it again next time.

@github-actions

Copy link
Copy Markdown
Contributor

Skills: review-workflows-blocks, review-topic-prediction-integrity

Reviewed the change: all 10 hunks are the identical description edit for the "Best" confidence mode ("Use F1-optimal thresholds...""Use F1-optimal per-class thresholds...") across the object-detection, instance-seg, semantic-seg, and multi-label-classification blocks (v3/v4 + tensor variants). No logic, defaults, control flow, or contracts change.

The new "per-class" wording is accurate: inference/core/entities/requests/inference.py:236-240 confirms "best" mode relies on per-class thresholds (keypoint detection explicitly rejects confidence="best" because model eval "does not yet produce per-class thresholds"). All prior occurrences of the old wording were updated (0 remain, 10 now use the new text). Behavior-neutral text change — no changelog/version bump required.

Reviewed at HEAD: b3b53fb

@github-actions

Copy link
Copy Markdown
Contributor

😎 PR passes the vibe-check and trust-me-bro verification.

@leeclemnet leeclemnet changed the title highlight per-class optimal threshlds in descriptions highlight 'per-class' in confidence mode descriptions Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant