-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure workflows steps #343
Restructure workflows steps #343
Conversation
"short_description": SHORT_DESCRIPTION, | ||
"long_description": LONG_DESCRIPTION, | ||
"license": "Apache-2.0", | ||
"block_type": "fusion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also block_type
may go out of sync with type
inference/enterprise/workflows/core_steps/transformations/detection_offset.py
Outdated
Show resolved
Hide resolved
|
||
def _validate_used_kinds_uniqueness(declared_kinds: List[Kind]) -> None: | ||
kinds_names_counter = Counter(k.name for k in declared_kinds) | ||
non_unique_kinds = [k for k, v in kinds_names_counter.items() if v > 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could do this same way as you have done a few lines above
kinds_names = [k.name for k in declared_kinds]
if len(declared_kinds) != len(set(declared_kinds)):
raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but my point was to deliver problematic elements in error message to provide more context
Description
This is new version of Execution Engine for
workflows
. Shipped changes:workflows
blocks with stateworkflows
blocks as standalone modules with interface that makes it possible to fully describe the behaviour of block and manifest it externally via OpenAPI 3.0 and custom metadata that are drawn automatically from the codeCondition
is no longer the only, hard-coded block with that capabilityworkflows plugins
workflow
block can be initialised automatically by EEType of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
Docs