Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken onnx versions halting ByteTrack install #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HenriqueSchmitz
Copy link

Description

Please include a summary of the change and which issue is fixed or implemented. Please also include relevant motivation and context (e.g. links, docs, tickets etc.).

I added a simple function to go over a requirements.txt file and remove the hardcoded version for a library and called this for the onnx, onnxruntime and onnx-simplifier libraries right after cloning the ByteTrack lib. When trying to run the how-to-track-football-players notebook I found that the versions provided for the onnx libs are incompatible with newer python versions used by google colab.

There is also a PR open for the ByteTrack lib for fixing this on ifzhang/ByteTrack#368, but as it seems to have lots of stale PRs and issues, I would suggest adding this fix while we wait for the lib to accept the fix.

List any dependencies that are required for this change.

No dependencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

I ran this code on my google colab, which was failing the bytetrack install and throwing an error when I tried to import anything from there. In my case it fixed that.

If you wish to test this fix too, you can copy this notebook to google colab and attempt to run the ByteTrack install sections and import both before and after the fixes.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

No.

Docs

  • Docs updated? What were the changes:

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants