Add analog servo control #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3d
commented
Jun 19, 2025
| Servo::Servo(uint8_t channel) { | ||
| this->channel = channel; | ||
| ledcSetup(channel, PWM_FREQ, PWM_RESOLUTION); // nastaveni PWM vystupu | ||
| // write(1500); |
Member
Author
There was a problem hiding this comment.
what this means? should we keep it?
Collaborator
There was a problem hiding this comment.
This is a default setting (middle servo position) for testing purposes.
m3d
commented
Jun 19, 2025
| P uint8 mode ... nastavení režimu gps (0 - vypnuto, 1 - surová data, 2 - ...) | ||
| V ... version | ||
|
|
||
| C uint16_t ... analogové servo na pinu GPIO4 (šířka pulzu 1000 ... 2000 us) |
Member
Author
There was a problem hiding this comment.
why 'C'? if you would extend the protocol for smart servos, you would use new command or extend this one?
Collaborator
There was a problem hiding this comment.
Why 'C', and why not (the first letter that came to mind). I would rather use a new command for smart servos.
Member
Author
|
I suppose that this PR is already part of #14 and we should abort it, correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one digital I/O remaining and ML recommended to use it for servo ... and this is his PR ;)