Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarp_add_idl use when cross-compiling #2983

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jul 6, 2023

In YARP are two CMake macros to run yarpidl programs, yarp_idl_to_dir and yarp_add_idl.

When cross-compiling (for exmaple for Android or iOS) , it is not possible for yarp_idl_to_dir and yarp_add_idl to call the yarpidl_rosmsg and yarpidl_thrift provided by the YARP that is used for linking the program, as that version tipically does not work for the system on which we are cross-compiling. For this reason, it is important that there is a way for users to specify manually the yarpidl_rosmsg and yarpidl_thrift executables that yarp_idl_to_dir and yarp_add_idl use.

Even before this PR, yarp_idl_to_dir works fine with cross-compilaton by specifing the CMake cache variables YARPIDL_thrift_LOCATION and YARPIDL_rosmsg_LOCATION. If this variables are not set, the one provided by the YARP used to link the applications are used instead.

Before this PR, yarp_add_idl was not using the executable specified in the YARPIDL_thrift_LOCATION and YARPIDL_rosmsg_LOCATION variable, while after this PR also yarp_add_idl works fine in cross-compilation.

@update-docs
Copy link

update-docs bot commented Jul 6, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@traversaro traversaro temporarily deployed to code-analysis July 6, 2023 20:29 — with GitHub Actions Inactive
@randaz81 randaz81 marked this pull request as draft August 5, 2023 10:53
@randaz81
Copy link
Member

randaz81 commented Aug 5, 2023

Marked as draft as discussed with @traversaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants