Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robotinterface: Do not print a message if a device does not derive from IWrapper #3126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

traversaro
Copy link
Member

robotinterface logs are always full of messages "is not an IWrapper. Trying IMultipleWrapper"

[INFO] Executing attach action, level 5 on device left_arm-mc_remapper with parameters [("networks" = "(left_arm_joints1)"), ("left_arm_joints1" = "left_arm_hardware_device")]
[INFO] left_arm-mc_remapper is not an IWrapper. Trying IMultipleWrapper
[INFO] Executing attach action, level 5 on device right_arm-mc_remapper with parameters [("networks" = "(right_arm_joints1)"), ("right_arm_joints1" = "right_arm_hardware_device")]
[INFO] right_arm-mc_remapper is not an IWrapper. Trying IMultipleWrapper
[INFO] Executing attach action, level 5 on device left_leg-mc_remapper with parameters [("networks" = "(left_leg_joints1)"), ("left_leg_joints1" = "left_leg_hardware_device")]
[INFO] left_leg-mc_remapper is not an IWrapper. Trying IMultipleWrapper
[INFO] Executing attach action, level 5 on device right_leg-mc_remapper with parameters [("networks" = "(right_leg_joints1)"), ("right_leg_joints1" = "right_leg_hardware_device")]
[INFO] right_leg-mc_remapper is not an IWrapper. Trying IMultipleWrapper
[INFO] Executing attach action, level 5 on device head-mc_remapper with parameters [("networks" = "(head_joints1)"), ("head_joints1" = "head_hardware_device")]
[INFO] head-mc_remapper is not an IWrapper. Trying IMultipleWrapper

However, this situation is quite normal as it is totally fine for a a device to only implement IMultipleWrapper and not IWrapper, so I think it could be a good idea to remove the " is not an IWrapper. Trying IMultipleWrapper" . I also modified the subsequent failure message if also IMultipleWrapper fails to be more descriptive.

Copy link

update-docs bot commented Aug 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant