Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robofab examples #606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

driehuis
Copy link
Contributor

I have converted as much of the original Robofab example code to fontParts as I could. I removed a few that were specific to Fontlab, others I could not get to work were moved to "helpneeded". There may still be something lurking in the working examples, but at first glance most seem to do what one would expect.

If you don't want all the examples in the repo I'm totally fine with that; in that case I'll create a seperate repo for the example code and provide a link.

@benkiel
Copy link
Member

benkiel commented Aug 12, 2021

@driehuis Thank you for this. I need to take a bit to review and see how it works in the current docs, it will take me a bit, but please nudge me after a week or so.

@benkiel
Copy link
Member

benkiel commented Aug 12, 2021

One thing I'd say is that we'd want to also port the written documentation (see https://github.com/robotools/robofab/tree/master/Docs/source/howtos) with the scripts, but this is a good step toward that (seriously, thank you so much). I think that it will be pretty painless to do so, but I can take a stab at it if you'd rather not

@driehuis
Copy link
Contributor Author

The hard part of course is making sure all the bits&bobs that are mentioned still make sense. One approach would be to just copy them over, make the obious changes, and put a warning on each and every one that they are not yet reviewed. Then, remove those warnings as pages get reviewed and fixed.

When getting the sample scripts to run I noticed quite a few things that will require significant rework (e.g. I could not get the kerning interface to work at all, RInfo is substantially different and doesn't seem to expost the font name, just to mention two that spring to mind).

The howtos and objects are the easiest to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants