-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roc test --ignore-error
flag
#6623
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @horriblename, I just improved some names. Can you add a test that uses the ignore-build-errors flag?
44fb83f
to
233d009
Compare
233d009
to
9aab0ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @horriblename!
4d1be22
to
cc458c0
Compare
@Anton-4 ci checks failed earlier as some commits are "partially verified", can you sign it again? |
I believe there was also a failure in the wasm tests but I'll run CI again and we'll see what happens 😄 |
Co-authored-by: Ayaz <[email protected]> Signed-off-by: Anton-4 <[email protected]>
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
closes #6622
adds new flag to allow tests to be run even if build errors occurred, like
roc run