-
Notifications
You must be signed in to change notification settings - Fork 84
Put db in UTC+1
for integration tests
#4224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tjenkinson is attempting to deploy a commit to the Rocicorp Team on Vercel. A member of the Team first needs to authorize it. |
@@ -198,6 +198,7 @@ CREATE TABLE IF NOT EXISTS "comments" ( | |||
"authorId" TEXT NOT NULL, | |||
"issue_id" TEXT NOT NULL, | |||
"text" TEXT NOT NULL, | |||
-- not TIMESTAMPTZ so that we're checking both TIMESTAMP and TIMESTAMPTZ behaviour | |||
"createdAt" TIMESTAMP NOT NULL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems weird to have 2 different types for time in the same db, but maybe this is fine for testing?
Otherwise maybe it should be a new column, but then more tests would need updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is fine for the test schema since we want to try various types.
Hmm I think the failures might be real. Bit confused because in But making that change still doesn't fix the tests |
Checking this out. Been on spring break over the last week. |
74a5e0d
to
44c9eda
Compare
This was caused by the CVR tests not inserting with a timezone and so defaulting to the server's timezone.
edit: looks like mono/packages/zero-cache/src/types/pg.ts Lines 48 to 71 in d042cb8
|
Followup for #4216
I tested (
zql-integration-tests
) with the patch in the above PR reverted and things broke, so this adds some coverage