Repository navigation
ci: remove the bump-version workflow - #56
Merged
Merged
Conversation
It pushes the version commit straight to main, which the main ruleset rejects: changes must go through a pull request and the merge queue, and its commits aren't signed by an allowed key. Document bumping the version in a pull request instead, as done for 1.1.5 and 1.1.6.
Contributor
Author
|
Verify Signed Commit Authors fails on Generated by Claude Code |
arv
force-pushed
the
arv/remove-bump-version
branch
from
October 19, 2026 12:36
6de5cbd to
7e25762
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
No open issues 🎉
What changed in this PR
Removes the obsolete version-bump workflow and documents the pull-request-based release process.
Changes:
- Deletes the rejected direct-push workflow.
- Updates release instructions and repository links.
| File | Description |
|---|---|
.github/workflows/bump-version.yml |
Removes the invalid automated version-bump workflow. |
docs/contribution.md |
Documents version bumps and releases from merged commits. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump-version.ymlrunsnpm versionand thengit push origin HEAD:main. Themainruleset rejects that push (failed run, GH013):Opening a PR from the workflow wouldn't fix this. The commit would be made by the Actions token, which isn't in
allowed_signers, so it would still fail Verify Signed Commit Authors.So this PR deletes the workflow and updates "Creating a release" in
docs/contribution.mdto the process actually used for 1.1.5 (#51) and 1.1.6 (#55):versionin a PR and merge it through the queue.v<version>tag on the merged commit.The release links now point to this repo instead of WiseLibs/better-sqlite3.
Generated by Claude Code