Skip to content

added getfile path #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added getfile path #2

wants to merge 4 commits into from
+96 −0

Conversation

behnamasadi
Copy link

added getfile path

@behnamasadi
Copy link
Author

added getfile path

@kavonszadkowski
Copy link
Contributor

Hi Behnam,

sorry to delay this again, but it seems you didn't change the header file along with the implementation. We should fix that before we merge into master. And while we're on it, we might as well make the commit history nicer, after all ;)

Cheers,

Kai

@behnamasadi
Copy link
Author

sure, I will clean it up and send an other request next week ;)

@behnamasadi
the function getFilesAbsolutePath has been clean up.
32bc7eb 
The private function "resolve_path" has been added to translate
 relative addresses to absolute address without pain.
A test file for test the code as been also added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behnamasadi @kavonszadkowski