Skip to content

Add a rocketpool update command - #1034

Merged
0xfornax merged 7 commits into
rocket-pool:masterfrom
jshufro:jms/integrated-updates
Mar 9, 2026
Merged

0xfornax merged 7 commits into
rocket-pool:masterfrom
jshufro:jms/integrated-updates

Conversation

@jshufro

@jshufro jshufro commented Mar 6, 2026 •

Copy link
Copy Markdown
Contributor

N.B. The last commit is utterly boring conversions of prompt.Confirm(fmt.Sprintf(...)) to just prompt.Confirm(). It was created with the help of AI. Without it, the tests fail due to lint errors.

The commits with meaty changes are these:
image

For testing, you will want to build the cli and then run rocketpool update --force, otherwise it won't replace itself because the version numbers will match (run rocketpool update as well to verify this).

After each time you run the command, the binary will be replaced by whatever is on github, so you will need to rerun the build to get back the functionality.

rocketpool update --force -y works to auto-accept prompts and always overwrite.

Please please please find a volunteer to test this on OSX. It should work, but I don't have the hw to test it.

@jshufro
jshufro force-pushed the jms/integrated-updates branch from 1613202 to 3ad84d7 Compare March 6, 2026 05:05
@jshufro
jshufro marked this pull request as draft March 6, 2026 16:26
@jshufro

jshufro commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Adding signature verification and reopening

@jshufro
jshufro force-pushed the jms/integrated-updates branch from 50e8dc2 to 8cf1788 Compare March 6, 2026 16:27
@jshufro
jshufro force-pushed the jms/integrated-updates branch from 8cf1788 to cd7ae28 Compare March 6, 2026 17:00
@jshufro
jshufro marked this pull request as ready for review March 6, 2026 17:03
@nickdoherty

Copy link
Copy Markdown
Contributor

Tested on OSX

λ ./rocketpool-cli update

Your detected os/architecture is darwin/arm64.

The cli at /Users/nickdoherty/Git/playground/smartnode/rocketpool-cli/rocketpool-cli will be replaced. Continue? [y/n]
y

Replacing the cli at /Users/nickdoherty/Git/playground/smartnode/rocketpool-cli/rocketpool-cli with the latest version...
Downloading the new binary from https://github.com/rocket-pool/smartnode/releases/latest/download/rocketpool-cli-darwin-arm64

Verifying the binary signature
Downloading the signature from https://github.com/rocket-pool/smartnode/releases/latest/download/rocketpool-cli-darwin-arm64.sig
Signed by 651023D62E70B5DD
  Fornax <dante@rocketpool.net>
You are already on the latest version of smartnode: 1.19.4.
λ ./rocketpool-cli update --force --y

Your detected os/architecture is darwin/arm64.

Replacing the cli at /Users/nickdoherty/Git/playground/smartnode/rocketpool-cli/rocketpool-cli with the latest version...
Downloading the new binary from https://github.com/rocket-pool/smartnode/releases/latest/download/rocketpool-cli-darwin-arm64

Verifying the binary signature
Downloading the signature from https://github.com/rocket-pool/smartnode/releases/latest/download/rocketpool-cli-darwin-arm64.sig
Signed by 651023D62E70B5DD
  Fornax <dante@rocketpool.net>
Updating from 1.19.4 to 1.19.4

The cli has been updated.

LGTM

@0xfornax
0xfornax merged commit 0d73191 into rocket-pool:master Mar 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants