Support for Rocq 9.2 - #40
Merged
Merged
Conversation
Collaborator
I think we should just make that the main branch. I don't want to have to worry about multiple branches. I think it's okay to just remove "coq" entirely and depend on "rocq-core" (any version). No reason to do extra work to support old versions like 8.20. CI will need updating to test more recent versions then. |
RalfJung
reviewed
Aug 6, 2026
Collaborator
|
Please do not make a single big PR that mixes multiple things. This PR should focus in just getting the opam package to work with rocq-core and updating CI. Fixing warnings can be done in a separate PR. |
skylee03
commented
Aug 6, 2026
skylee03
marked this pull request as ready for review
August 6, 2026 15:10
RalfJung
reviewed
Aug 6, 2026
RalfJung
left a comment
RalfJung
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks good, just minor comments.
RalfJung
reviewed
Aug 6, 2026
Collaborator
|
Looks good, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rocq 9.2, the
coqpackage is no longer available via OPAM. Our package should instead depend onrocq-coreandrocq-stdlibseparately.We are expected to generate the OPAM file from
meta.ymlusinggenerate.sh. However, the generator currently does not support depending onrocq-*packages in place ofcoq(see rocq-community/templates#142). It also appears thatgenerate.shis no longer actively maintained.Until
generate.shis updated, I propose that we maintain a separate branch with a manually writtencoq-autosubst.opamfile. This would allow us to pin on that branch and use Autosubst with Rocq 9.2 without waiting for the generator to be fixed.