Implementations of error reporting, positions, and branch committing#18
Merged
Merged
Conversation
Member
gallais
approved these changes
Jun 15, 2026
Member
|
after merging, do you need a release @raoxiaojia? |
Contributor
Author
Thanks! A release would be useful for downstream error reporting, however I will not have time to work on that until at least after the POPL deadline, so there's no urgency in this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements error reporting and branch committing functions, which was implemented in the Agdarsec updates mentioned by @gallais 's blog post in #4 . This does not implement the other functionalities that were added in Agdarsec, e.g. annotations. The changes made here should be backward compatible (at least for my use case).
This probably needs a review from the original authors, as I've introduced quite a bit of new code here while trying to imitate Agdarsec's style; but I don't really know Agda well, so I could have made some dumb decisions here.
I added the example mentioned in the blog post (binary/hex parser commitment) in
Examples.vto demonstrate that the design works.