Evaluate DUNE_IN_FILES eagerly#1263
Merged
Merged
Conversation
Otherwise it is evaluated multiple times per a call to `make`. This is especially slow when `find` looks through `_build` and `_opam` directories which are large.
KacperFKorban
approved these changes
Jun 14, 2026
gares
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it is evaluated multiple times per a single call to
make. This is especially slow whenfindlooks through_buildand_opamdirectories which are large. In my case runningmakewould take 15 seconds.Also I moved some gitignore. Makes it more scoped and the ignores also work in editors if you open only the subfolder.