fix: createTile silently drops pinned/savedForLater/reactions + add tile-validation tests#11
Open
cobyfrombrooklyn-bot wants to merge 1 commit intomainfrom
Conversation
The createTile SQL INSERT was only inserting id, type, content, source, and tags — silently dropping pinned, savedForLater, and reactions even though the TypeScript type accepted them. Also adds vitest and 25 comprehensive tests for tile-validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
createTile()indb.tsacceptedpinned,savedForLater, andreactionsin its TypeScript type signature, but the SQL INSERT only wroteid, type, content, source, tags. This meant:pinned: true→ tile appears unpinnedsavedForLater: true→ tile appears in main feedFix: Added
pinned,saved_for_later, andreactionsto the INSERT statement.Tests
Added 25 unit tests for
tile-validation.tscovering:getRequiredFields,getAllRequiredFields)Also added
vitestas a dev dependency andtest/test:watchnpm scripts.