Skip to content

fix: restore resolved badge contrast #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogerdigital merged 1 commit into from
Sep 7, 2026
Merged

fix: restore resolved badge contrast #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/tests/styles.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ describe("styles.css", () => {
expect(mobile).toMatch(/\.vi-bulk-excluded-note\s*\{[^}]*overflow-wrap:\s*anywhere;/);
});

it("keeps confirmed and eligible statuses compact and contrast-safe", async () => {
it("keeps confirmed, eligible, and resolved statuses compact and contrast-safe", async () => {
const css = await readFile("styles.css", "utf8");

expect(css).toMatch(
Expand All @@ -176,6 +176,7 @@ describe("styles.css", () => {
for (const className of [
"vi-classification-confirmed",
"vi-eligibility-eligible",
"vi-status-resolved",
]) {
const rule = css.match(new RegExp(`\\.${className}\\s*\\{([^}]*)\\}`))?.[1];
expect(rule, `missing .${className}`).toBeDefined();
Expand Down
2 changes: 1 addition & 1 deletion styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
.vi-classification-unverified { background: var(--background-secondary); color: var(--text-muted); }
.vi-status-new { background: var(--interactive-accent); color: var(--text-on-accent); }
.vi-status-persisting { background: var(--background-secondary); color: var(--text-muted); }
.vi-status-resolved { background: var(--background-modifier-success); color: var(--text-success); }
.vi-status-resolved { background: var(--background-secondary); color: var(--text-success); border: 1px solid var(--text-success); }

.vi-explanation { min-width: 0; margin-top: 4px; padding: 8px 10px; border-left: 2px solid var(--background-modifier-border); background: var(--background-secondary); }
.vi-explanation-row { display: grid; grid-template-columns: max-content minmax(0, 1fr); min-width: 0; align-items: baseline; }
Expand Down