Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IaC (Bicep) for provisioning dependencies/ui #18

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

slamb2k
Copy link

@slamb2k slamb2k commented May 24, 2023

PR Summary

Added Bicep templates for:

  1. OpenAI Service
  2. Speech Service
  3. Tech Analytics Service
  4. UI App Service
  5. API App Service

Having both the UI and API use an App Service each is not the ideal implementation and will be updated to use something like an Azure Static Web App for the ReactJS content.

Included README.md in infra folder to provide guidance for manual execution of Bicep templates. Intend to add GitHub Action workflows for all the above infra pipelines and will add documentation when complete.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

Copy link
Owner

@rohit-lakhanpal rohit-lakhanpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @slamb2k. Keen to get your thoughts against the comments below.

Also, is there scope to add "Deploy to Azure" functionality? This would help the new to azure folk.

```

Then, create a resource group if it does not already exist:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worthwhile adding instructions around the following:

  1. Use something like to showcase possible locations
az account list-locations --query "[*].name" --out tsv | sort 
  1. Additionally, should we reference https://learn.microsoft.com/en-us/azure/cognitive-services/openai/concepts/models#gpt-3-models-1 to showcase region availability for GPT-3 and 4 models?

#### :wrench: CREATING THE RESOURCE GROUP ####

Before executing any of the following Bicep templates, you first need to login to your Azure account using the Azure CLI `az` command line tool:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of making things easy/inclusive for new to azure folk, should we add a paragraph about bicep.

Also explicitly add the following?

cd infra


## Deploying infastructure continuously using GitHub Actions

Coming soon...
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also review actions in the deploy branch? Would love to get your feedback on this.
https://github.com/rohit-lakhanpal/ai-hackathon-starter-kit/blob/deploy/.github/workflows/deploy_ai-hackathon-starter-kit-dev.yml

To deploy the required web infrastructure, deploy the `web.bicep` file with the `az deployment group create` command:

```bash
az deployment group create --resource-group <ResourceGroupName> --template-file web.bicep
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add any comments/gotchas here for expected errors?
Eg. "This subscription has reached the limit of 1 Free Linux app service plan(s) it can create in this region. Please choose a different sku or region."

@slamb2k
Copy link
Author

slamb2k commented Jun 8, 2023

Hey Brother. I'm sorry I've dropped the ball on this but I'll respond to your questions after dinner and update the PR with the rest of the stuff I wanted to add. Don't give up on me!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants