Skip to content

fix(docs): sync REST endpoint counts + skills reference (unblocks CI on main) - #1147

Open
berthojoris wants to merge 2 commits into
rohitg00:mainfrom
berthojoris:fix/rest-endpoint-count
Open

fix(docs): sync REST endpoint counts + skills reference (unblocks CI on main)#1147
berthojoris wants to merge 2 commits into
rohitg00:mainfrom
berthojoris:fix/rest-endpoint-count

Conversation

@berthojoris

@berthojoris berthojoris commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

What

Updates the documented REST endpoint count from 129 to 130 in the three places test/consistency.test.ts checks.

Why

main is currently red. 5023cf3 (#1132) registered a 130th api_path: in src/triggers/api.ts without updating any of the documented counts, so this assertion fails on every PR:

test/consistency.test.ts > Consistency checks > documented REST endpoint counts match registered API paths
AssertionError: expected '<p align="center">…' to contain '130 endpoints on port'

Failing CI run on main for 5023cf3: https://github.com/rohitg00/agentmemory/actions?query=branch%3Amain

AGENTS.md already documents this coupling — "When adding REST endpoints, you MUST update: src/triggers/api.ts, src/index.ts, README.md". This PR moves those two, plus the AGENTS.md stat line that the same test also asserts on.

  • src/index.ts:543 — boot log line
  • README.md:1501 — API section prose
  • AGENTS.md:120 — Current Stats

No endpoint is added or removed; this is documentation catching up to code.

How to verify

npx vitest run test/consistency.test.ts

8 passed (was 1 failed / 7 passed).

The count itself is Array.from(src.matchAll(/api_path:\s*["]/g)).lengthoversrc/triggers/api.ts, which is 130 at 5023cf3`.

Summary by CodeRabbit

  • Documentation

    • Updated the README and project guidance to reflect 130 available REST API endpoints.
    • Updated the REST API reference to report 119 registered endpoints.
  • Bug Fixes

    • Corrected the startup readiness message so it reports the current total of 130 REST API endpoints.

5023cf3 (rohitg00#1132) registered a 130th endpoint in src/triggers/api.ts but
left the three documented counts at 129, so
`test/consistency.test.ts > documented REST endpoint counts match
registered API paths` fails and CI on main is red.

AGENTS.md already requires all three to move together when an endpoint
is added; this updates the two it lists (src/index.ts boot log, README
prose) plus the AGENTS.md stat line itself.

Signed-off-by: Bertho Joris <bertho_joris@yahoo.co.id>
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

@berthojoris is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change updates REST endpoint counts in project documentation, the startup readiness log, and the REST API reference.

Changes

REST endpoint count

Layer / File(s) Summary
Endpoint count documentation and logging
AGENTS.md, README.md, src/index.ts
Documentation and the startup readiness log now report 130 REST endpoints instead of 129.
REST API reference count
plugin/skills/agentmemory-rest-api/REFERENCE.md
The REST API reference now reports 119 registered endpoints instead of 118.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: rohitg00, somsamantray

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the documentation count updates and REST API skills reference synchronization.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

`npm run skills:check` is a separate CI gate from the consistency test
and fails on main for the same root cause: 5023cf3 (rohitg00#1132) registered a
new endpoint without running `npm run skills:gen`, leaving the
AUTOGEN:rest block in plugin/skills/agentmemory-rest-api/REFERENCE.md at
118 registered endpoints.

Only the rest-api reference has a content change; the other four
REFERENCE.md files regenerate byte-identical.

Signed-off-by: Bertho Joris <bertho_joris@yahoo.co.id>
@berthojoris berthojoris changed the title fix(docs): sync REST endpoint count to 130 (unblocks CI on main) fix(docs): sync REST endpoint counts + skills reference (unblocks CI on main) Aug 3, 2026
@berthojoris

Copy link
Copy Markdown
Contributor Author

Pushed a second commit: main fails two independent CI gates from the same root cause, not one.

  1. npm testtest/consistency.test.tsREADME.md / AGENTS.md / src/index.ts still said 129 endpoints (first commit).
  2. npm run skills:checkplugin/skills/agentmemory-rest-api/REFERENCE.md — the AUTOGEN:rest block still said 118 registered endpoints because npm run skills:gen was not run (second commit).

Both trace back to 5023cf3 (#1132) adding an endpoint without the follow-up updates AGENTS.md requires. Only the rest-api reference has a content change; the other four REFERENCE.md files regenerate byte-identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant