Skip to content

Fix slot MCP errors and Windows test portability - #1149

Draft
arkhipowiktor-dev wants to merge 15 commits into
rohitg00:mainfrom
arkhipowiktor-dev:codex/fix-agentmemory-errors
Draft

Fix slot MCP errors and Windows test portability#1149
arkhipowiktor-dev wants to merge 15 commits into
rohitg00:mainfrom
arkhipowiktor-dev:codex/fix-agentmemory-errors

Conversation

@arkhipowiktor-dev

@arkhipowiktor-dev arkhipowiktor-dev commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • return a structured MCP response when memory-slot tools are disabled instead of triggering an unregistered function and producing HTTP 500
  • treat sessionless memories as intentionally global while retaining migration warnings for session-linked unscoped memories
  • make Windows tests use platform-aware executable names and paths
  • synchronize the documented REST endpoint count with the current 130 registered paths

Root cause

The MCP tool surface was visible independently of the AGENTMEMORY_SLOTS registration gate. Diagnostics also assumed every unscoped memory could be backfilled from sessions, although sessionless memories have no project evidence. Several tests encoded Unix-only path and binary-name assumptions. After rebasing, the current upstream endpoint counter was also one behind the registered API paths.

Changed files

  • runtime: src/mcp/server.ts, src/functions/diagnostics.ts
  • regression coverage: test/mcp-slots-disabled.test.ts, test/diagnostics.test.ts
  • Windows portability: test/cli-remove.test.ts, test/compress-file.test.ts, test/copilot-plugin.test.ts, test/obsidian-export.test.ts, test/slots-flag-gate.test.ts
  • synchronized counts: README.md, AGENTS.md, src/index.ts

Validation

  • npm test — passed on the rebased head
  • npx tsdown — passed on the rebased head
  • git diff --check — passed
  • live /agentmemory/health — healthy
  • live diagnostics — 3 pass, 0 warn, 0 fail
  • live memory_slot_list — actionable disabled-feature response, no HTTP 500

Risks and limitations

  • Memory slots remain opt-in; this change does not enable them automatically.
  • Sessionless memories remain global and no stored memory data is rewritten.
  • Vercel deployment authorization is controlled by the upstream owner and is not exercised by this runtime/test-only change.

Scope confirmation

  • No environment files, credentials, stored memory data, deployment configuration, or unrelated product areas were changed.
  • Generated hook bundles were excluded from the commit.

Exact head

  • Commit: 31776a7
  • CI: pending after rebased force-with-lease update

Closes #1148

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

@arkhipowiktor-dev is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ee663d2-892e-40af-8568-700f6ba391a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arkhipowiktor-dev
arkhipowiktor-dev force-pushed the codex/fix-agentmemory-errors branch from 07c0e63 to 31776a7 Compare August 3, 2026 08:36
@arkhipowiktor-dev

Copy link
Copy Markdown
Author

BLOCKED — upstream owner action required before Ready/merge.

Exact head 31776a78f871fe4215fee7648c7dd535ccd4122c is mergeable, has no review threads, and passes the complete local test/build validation recorded in the PR body. GitHub currently reports mergeStateStatus: UNSTABLE because the Vercel status is failing with Authorization required to deploy.

Repository rulesets do not list this as a required check, but the repository merge gate prohibits merging with any failing check. A maintainer with access to the upstream Vercel team must authorize/re-run the deployment status or explicitly resolve the status before this PR can be moved to Ready and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix disabled slot MCP errors and Windows test portability

1 participant