forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
Draft replace rapidjson with simdjson #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rok
wants to merge
92
commits into
main
Choose a base branch
from
simdjson
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
15b09ee
replace rapidjson with simdjson
rok 8ac6441
some changes
rok 5a811b0
chunker and lint
rok 60ae876
match NaN/Inf to rapidjson
rok edcabd8
inf behavior
rok fbe65f2
docs
rok b87c138
missing example
rok 54fb33e
add import on windows
rok 2cb9f3f
windows workaround
rok cb689a9
fix failing python test
rok 17424f6
error message
rok dcdbac9
lint
rok 26828c6
lint and error message
rok d77ff7f
change SIMDJSON_IMPORTED_LOCATION
rok e3fe514
unity build
rok f6f1889
refactor cmake
rok 53da804
bug
rok 52e995b
chunker
rok d982716
cmake and chunker
rok 412b1c7
windows and amazon linux fixes
rok 372b1e3
cmake
rok f6b680f
cmake
rok 08c27b8
msvc issues
rok e8b54e1
cmake debug
rok 48ca9a2
cmake refactor
rok b7f0bfb
cmake benchmark enable
rok a0b2beb
lint
rok 1b66a7a
cmake
rok 8c595e8
cmake
rok 72f53f9
more cmake
rok fc1d6fe
google deprecated benchmark::internal::Benchmark
rok 877f92a
benchmark
rok d6c2315
benchmark workaround
rok dea2662
benchmark_util and lint
rok 419691c
benchmark change
rok 094b8af
benchmark cmake
rok dc98e1a
changes
rok 0542887
dll fix
rok e622532
On Windows with vcpkg, always use header-only mode.
rok 6a7dd01
memory_benchmark.cc
rok 45f74af
memory_benchmark.cc
rok 57d1a53
work
rok 5ce7341
work
rok 0ca7290
work
rok 4f61960
work
rok 16f28b0
work
rok 956f8e4
cmake
rok 385bc10
cmake
rok aab301f
vcpkg cmake
rok 7f04187
cmake
rok bfd026f
cmake debug
rok d632fc8
more cmake
rok cba3ab8
more cmake
rok f43e386
more cmake
rok 34c31d9
vcpkg cmake
rok 9137ae4
cmake
rok 9642da0
cmake
rok ed6fb88
lint
rok 67a088f
cmake
rok 4d653ce
cmake
rok da134f7
cmake and higher simdjson version
rok b975ae2
cmake
rok 5d91095
replace objectwriter with builder
rok 260aca3
switch to simdjson's builder for writing json
rok 49b6327
cmake
rok 89d75b5
cmake
rok ac10f3e
cmake
rok 852ef6f
make escape characters uppercse
rok d66ef5a
cmake
rok 8f48444
cmake
rok 61296f1
cmake
rok 343dda0
cmake
rok 7cf6df0
cmake
rok 63d8f3e
cmake
rok 28ae1db
cmake
rok fb52c90
cmake
rok cf1f66c
lint
rok 355a9f2
fix simdjson version in conan
rok 84af758
simplification
rok bb6f94c
fix
rok e696611
cmake
rok 06cb2ce
cmake
rok bc16df5
cmake
rok 734da24
cmake
rok d8f55d5
cmake
rok 56f0185
cmake
rok 142193c
cmake
rok 017cdec
cmake
rok ae9b2e7
cmake
rok 76ee292
cmake and lint
rok f4386b0
cmake
rok 19f136b
cmake
rok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ nodejs>=16 | |
| orc<2.1.0 | ||
| pkg-config | ||
| python | ||
| rapidjson | ||
| simdjson | ||
| re2 | ||
| snappy | ||
| thrift-cpp>=0.11.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ apt install -y \ | |
| python3-pip \ | ||
| python3-rados \ | ||
| rados-objclass-dev \ | ||
| rapidjson-dev \ | ||
| libsimdjson-dev \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as above |
||
| tzdata \ | ||
| wget | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ | |
| "json": { | ||
| "description": "JSON support", | ||
| "dependencies": [ | ||
| "rapidjson" | ||
| "simdjson" | ||
| ] | ||
| }, | ||
| "gandiva": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required when you bundle simdjson in all cases?