Skip to content

Handle null nextDescription in describeElement #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle null nextDescription in describeElement #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78e54c2
Handle null nextDescription in describeElement
jalada Oct 14, 2025
f2fd276
Add a regression test for genElement handling elements with no tagName
jalada Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/domUtility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function treeToArray(elem) {
var nextDescription;
for (var height = 0; elem && height < MAX_HEIGHT; height++) {
nextDescription = describeElement(elem);
if (nextDescription.tagName === 'html') {
if (!nextDescription || nextDescription.tagName === 'html') {
Copy link
Contributor

@matux matux Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!nextDescription || nextDescription.tagName === 'html') {
if (nextDescription == null || nextDescription.tagName?.toLowerCase() === 'html') {

Copy link
Author

@jalada jalada Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the ? if it's null? The code in describeElement looks like it reliably sets a tagname if not. It also already calls toLowerCase() when setting it.

Just being extra defensive?

break;
}
out.unshift(nextDescription);
Expand Down
5 changes: 5 additions & 0 deletions test/browser.domUtility.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ describe('treeToArray', function () {
var arr = d.treeToArray(e1);
expect(arr.length).to.eql(5);
});
it('should handle elements without tag names', function () {
var e1 = genElement(null);
var arr = d.treeToArray(e1);
expect(arr).to.eql([]);
});
it('should put the innermost element last', function () {
var e1 = genElement('div', 'id1');
var e2 = genElement('div', 'id2', 'a b');
Expand Down