Add the STRONG_TYPE_MODULE_EXPORT to all entities that should be exported, aka strong_type module part 1 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted in a module Set STRONG_TYPE_MODULE_EXPORT to empty if not defined
davidhunter22
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 338 356 +18
=========================================
+ Hits 338 356 +18 ☔ View full report in Codecov by Sentry. |
rollbear
reviewed
Sep 7, 2024
| * strong_type C++14/17/20 strong typedef library | ||
| * | ||
| * Copyright (C) Björn Fahller | ||
| * |
There was a problem hiding this comment.
I wouldn't mind if you added your own name here. It's a substantial contribution.
|
Are you waiting on me to do anything on this and the other PR? |
|
No, sorry, I got stuck on a ton of other things. It is not impossible that I will ask for your assistance, but for the moment I'm a bit swamped with other things. |
|
No problem I'll just check back every so often |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a macro STRONG_TYPE_MODULE_EXPORT.
This at some point will expand to
exportin a module build and empty in a non module build.Only entities in the strong_type namespace were decorated, anything in "impl", "detail" etc... namespaces were not, although see below.
The header file
type.hppcontainsThis allows existing include users to carry on including without any changes
There should be no other changed in this patch. In my local build I have built a module and built all the test cases against it, at least on MSVC. In doing this there were two methods called
accessin the type.hpp header that are used in the implementation of other exported stuff so they had to be exported.I included the strong_type.ixx file just for you interest, it will probably change a bit from this. I believe that all the other changes in the library header files are messing around with
#includestuff by macroing them in or out as necessary.These changes should not overlap at all with the
import std;pull request so could be applied in either order.