Skip to content

Code improvements #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sstok merged 1 commit into from
Feb 3, 2026
Merged

Code improvements #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Constraints/NotInPasswordCommonListValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function validate($value, Constraint $constraint): void
return;
}

if (! \is_scalar($value) && ! (\is_object($value) && method_exists($value, '__toString'))) {
if (! \is_scalar($value) && ! $value instanceof \Stringable) {
Copy link
Contributor Author

@gharlan gharlan Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP 8 implicitly implements Stringable for all classes with __toString method.

throw new UnexpectedValueException($value, 'string');
}

Expand All @@ -39,7 +39,7 @@ public function validate($value, Constraint $constraint): void

$passwordFile = __DIR__ . '/../../Resources/common_lists/list-' . mb_strlen($value) . '.php';

if (! file_exists($passwordFile)) {
if (! is_file($passwordFile)) {
Copy link
Contributor Author

@gharlan gharlan Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_file is faster because of caching.

return;
}

Expand Down
Loading