Skip to content

refactor(pluginutils): use pathe to support browser environments#1838

Closed
zhiyuanzmj wants to merge 1 commit intorollup:masterfrom
zhiyuanzmj:pathe
Closed

refactor(pluginutils): use pathe to support browser environments#1838
zhiyuanzmj wants to merge 1 commit intorollup:masterfrom
zhiyuanzmj:pathe

Conversation

@zhiyuanzmj
Copy link
Copy Markdown

@zhiyuanzmj zhiyuanzmj commented Jan 17, 2025

Rollup Plugin Name: pluginutils

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Uses pathe instead of Node's native path module to support browser environments

@zhiyuanzmj zhiyuanzmj changed the title feat(pluginutils): use pathe to support browser environments refactor(pluginutils): use pathe to support browser environments Jan 17, 2025
@zhiyuanzmj zhiyuanzmj marked this pull request as draft January 17, 2025 08:08
@zhiyuanzmj zhiyuanzmj marked this pull request as ready for review January 17, 2025 15:17
@shellscape
Copy link
Copy Markdown
Collaborator

Without discussion on why this is needed, I'm not inclined to approve this. Why not just alias path to pathe within bundler configuration?

@zhiyuanzmj
Copy link
Copy Markdown
Author

zhiyuanzmj commented Mar 6, 2025

Thanks for your reply.

I created a REPL supports rollup plugins, but when plugin are using createFilter that's will be don't support browser.
https://repl.zmjs.dev/vue-macros/vue-jsx-vapor

No matter, this maybe not a popular demand. you can close it at will.

@shellscape
Copy link
Copy Markdown
Collaborator

Yes I think a fork here would be more appropriate. Thank you for the PR none the less.

@shellscape shellscape closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants