Skip to content

fix(pluginutils): only normalize/parse patterns once in createFilter #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −13
Open

fix(pluginutils): only normalize/parse patterns once in createFilter #1921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions packages/pluginutils/src/createFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,16 @@ function getMatcherString(id: string, resolutionBase: string | false | null | un
const createFilter: CreateFilter = function createFilter(include?, exclude?, options?) {
const resolutionBase = options && options.resolve;

const getMatcher = (id: string | RegExp) =>
id instanceof RegExp
? id
: {
test: (what: string) => {
// this refactor is a tad overly verbose but makes for easy debugging
const pattern = getMatcherString(id, resolutionBase);
const fn = pm(pattern, { dot: true });
const result = fn(what);

return result;
}
};
const getMatcher = (id: string | RegExp) => {
if (id instanceof RegExp) {
return id;
}
const pattern = getMatcherString(id, resolutionBase);
const fn = pm(pattern, { dot: true });
return {
test: (what: string) => fn(what)
};
};

const includeMatchers = ensureArray(include).map(getMatcher);
const excludeMatchers = ensureArray(exclude).map(getMatcher);
Expand Down
Loading