Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project URL in POM #644

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Conversation

makigumo
Copy link
Contributor

The old link is pointing to some unrelated Chinese website.

@PatrickGotthard
Copy link
Member

Hi @makigumo,

thanks for your contribution. Unfortunately the GitHub Pages will be deleted soon because I'm working on a new documentation (see #498). So either we should link

Regards,
Patrick

@makigumo
Copy link
Contributor Author

Thank you for your feedback.
I have updated the link to point to the new documentation page. I went with https://rome.readthedocs.io/ which redirects to https://rome.readthedocs.io/en/latest and https://github.com/rometools/rome is already set as scm-url. I hope this is fine.

@PatrickGotthard
Copy link
Member

PatrickGotthard commented Mar 19, 2023

Hi @makigumo,

I prefer to use https://github.com/rometools/rome as main homepage.
Please update your PR accordingly and I' ll add a link to the new documentation to the README as soon as it's ready.

Regards,
Patrick

@makigumo
Copy link
Contributor Author

Understood. I updated accordingly.

@PatrickGotthard PatrickGotthard changed the title pom.xml: update project url Update project URL in POM Mar 19, 2023
@PatrickGotthard PatrickGotthard merged commit ea82b4a into rometools:master Mar 19, 2023
@makigumo makigumo deleted the patch-1 branch March 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants