DIALOG_TITLE argument is without effect on Marshmallow#391
Open
mtotschnig wants to merge 1 commit intoroomorama:masterfrom
Open
DIALOG_TITLE argument is without effect on Marshmallow#391mtotschnig wants to merge 1 commit intoroomorama:masterfrom
mtotschnig wants to merge 1 commit intoroomorama:masterfrom
Conversation
…need to set it otherwise DIALOG_TITLE argument does not work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
If you try to set a dialog title for a Caldroid dialog with
the title is not shown on Marshmallow devices.
Reason
The default for windowNoTitle is false for Lollipop and below, but true on Marshmallow. Compare with http://stackoverflow.com/a/32711916/1199911
Solution
Set windowNotTitle explicitly to false.