Skip to content

Add tests for first C++ types #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Add tests for first C++ types #36

merged 3 commits into from
Feb 27, 2025

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Feb 18, 2025

@hahnjo hahnjo added the types label Feb 18, 2025
@hahnjo hahnjo self-assigned this Feb 18, 2025
Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few minor comments.

Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final suggestion but LGTM otherwise!

... with all possible index column types.

Closes root-project#2
... with all possible index column types.

Closes root-project#3
@hahnjo hahnjo added this to the 1.0 milestone Feb 20, 2025
@hahnjo hahnjo requested a review from pcanal February 24, 2025 09:46
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@hahnjo hahnjo merged commit 3c426b3 into root-project:main Feb 27, 2025
@hahnjo hahnjo deleted the types-cpp branch February 27, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for std::variant type Tests for std::vector type Test for std::string type
3 participants