[cppyy] Add CMakeLists.txt for cppyy/test #18671
Conversation
Vipul-Cariappa
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
Enabling running tests using `ctest`
Vipul-Cariappa
force-pushed
the
dev/test/cppyy-cmake
branch
from
0a643e1 to
e8e6b75
Compare
Test Results 18 files 18 suites 3d 21h 24m 14s ⏱️ For more details on these failures, see this check. Results for commit c438360. ♻️ This comment has been updated with latest results. |
|
Thanks for this very nice PR! Looks like the bots fail because the makefile requires |
| foreach(CPPYY_TEST_FILE ${CPPYY_TEST_SRC}) | ||
| get_filename_component(CPPYY_TEST_FILE_NAME ${CPPYY_TEST_FILE} NAME) | ||
| string(REPLACE ".py" "" CPPYY_TEST_FILE_NO_EXT ${CPPYY_TEST_FILE_NAME}) | ||
|
|
There was a problem hiding this comment.
We need something like: https://github.com/root-project/root/blob/master/roottest/cling/stl/dicts/CMakeLists.txt, where the ROOT_GENERATE_DICTIONARY macro can be used in the CMake to perform the generation of the dictionaries, followed by ROOT_LINKER_LIBRARY with the sources for each test. We can then drop the makefile completely :)
|
|
||
| add_custom_target(cppyy_tests_dict ALL COMMAND make all WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/bindings/pyroot/cppyy/cppyy/test) | ||
|
|
||
| file(GLOB CPPYY_TEST_SRC "test_*.py") |
There was a problem hiding this comment.
We try to avoid globs in general: could we perhaps be explicit listing the test files we want to add to the list?
Generating rootmaps and shared libraries for the tests using cmake. Fix formatting.
Vipul-Cariappa
force-pushed
the
dev/test/cppyy-cmake
branch
from
d811bd6 to
c438360
Compare
|
Hi @Vipul-Cariappa! I see there are some failures in the CI. Can you investigate next week please? Thanks! |
Yes. I plan on doing that. I had a long conversation with Aaron yesterday on some weird behaviour. Maybe I can share the details with you in the office on Monday. |
|
Excellent, thanks! |
Enabling running tests using
ctest