Skip to content

[roottest] use cmake for io/abstractclasses #18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linev
Copy link
Member

@linev linev commented May 14, 2025

Build dictionary first using normal rootcling - before rootcint in Makefile was invoked.
Causes warning on some platforms:

/github/home/ROOT-CI/build/roottest/root/io/abstractclass/libAbstractClasses.cxx: In function ‘void ROOT::delete_PureAbstractInterface(void*)’:
  /github/home/ROOT-CI/build/roottest/root/io/abstractclass/libAbstractClasses.cxx:327:7: error: deleting object of abstract class type ‘PureAbstractInterface’ which has non-virtual destructor will cause undefined behavior [-Werror=delete-non-virtual-dtor]
    327 |       delete (static_cast<::PureAbstractInterface*>(p));
        |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cc1plus: all warnings being treated as errors
``

Use ROOT files from v3 and v4 to check reading functionality
Also test reading of recently created files

Remove data.root while it is identical with data_v3_05.root

Copy link

github-actions bot commented May 14, 2025

Test Results

    18 files      18 suites   3d 7h 32m 45s ⏱️
 2 749 tests  2 749 ✅ 0 💤 0 ❌
48 325 runs  48 325 ✅ 0 💤 0 ❌

Results for commit cf53433.

♻️ This comment has been updated with latest results.

Build dictionary first
Use ROOT files from v3 and v4 to check reading functionality
Remove data.root while it is identical with data_v3_05.root
Add -Wno-delete-non-virtual-dtor to avoid warning
@linev linev force-pushed the test_io_abstractclasses branch from 1e31c14 to cf53433 Compare May 15, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant