[ntuple] Adapt hashing to 32-bit #18749
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit platforms or platforms where `std::size_t` is 32-bit instead of 64-bit, the current `mix` function doesn't work. The alternative added with this change also originates from the `boost::hash_combine` writeup linked in the class documentation.
silverweed
approved these changes
May 16, 2025
bellenot
requested changes
May 16, 2025
Comment on lines
+128
to
+132
| init ^= init >> 32; | ||
| init *= 0xe9846af9b1a615d; | ||
| init ^= init >> 32; | ||
| init *= 0xe9846af9b1a615d; | ||
| init ^= init >> 28; |
There was a problem hiding this comment.
To disable compilation warnings on Windows:
Suggested change
| init ^= init >> 32; | |
| init *= 0xe9846af9b1a615d; | |
| init ^= init >> 32; | |
| init *= 0xe9846af9b1a615d; | |
| init ^= init >> 28; | |
| #ifdef _MSC_VER | |
| #pragma warning(push) | |
| #pragma warning(disable:4293) | |
| #endif | |
| init ^= init >> 32; | |
| init *= 0xe9846af9b1a615d; | |
| init ^= init >> 32; | |
| init *= 0xe9846af9b1a615d; | |
| init ^= init >> 28; | |
| #ifdef _MSC_VER | |
| #pragma warning(pop) | |
| #endif |
Test Results 19 files 19 suites 3d 16h 22m 22s ⏱️ For more details on these failures, see this check. Results for commit b4475e9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit platforms or platforms where
std::size_tis 32-bit instead of 64-bit, the currentmixfunction doesn't work. The alternative added with this change also originates from theboost::hash_combinewriteup linked in theRCombinedJoinFieldValueHashclass documentation.