[cppyy] Remove unused template instance pattern rule #19202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files 20 suites 3d 6h 59m 40s ⏱️ Results for commit c7a1cbb. |
|
Can this be merged to remove the warning during the build? |
|
ping @dpiparo. Do we have to wait for upstream or can we get rid of the (annoying, but harmless) warning? |
As there are no instances to match.
guitargeek
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Since the discussion in the PR to Wims repo didn't conclude yet, I'd suggest to merge this PR to ROOT for now to fix the warning, but with an added patch file to keep track of the differences. I have added this to the PR here. Thanks again @dpiparo for the initiative!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as there are no instances to match.
This PR fixes #19189