-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] use cmake for io/perf
tests
#19219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run julius.C Also run ReadBuffer/WriteBuffer tests - without direct sinfo methods
SergeiShortTest and SergeiHardTest not included - while consume a lot of time
Like in Makefile, first run reference and measure time After that run all tests and check them with reference time
pcanal
reviewed
Jun 27, 2025
pcanal
reviewed
Jun 27, 2025
Just run all macros in compiled mode Only exclude vectorsptrtclass - it uses private members
Test Results 20 files 20 suites 3d 19h 30m 14s ⏱️ Results for commit fcc3a37. ♻️ This comment has been updated with latest results. |
Remove unused reference files, Most of tests are failing - only atlas file has two tests passing Actual failures can be investigated later While tests taking extremely long time - put then under `very_long_tests` condition
pcanal
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root/io/perf
directory run most macros - not onlyjulius.C
.ShortTest
/HardTest
takes too long and creating huge files - therefore put underif(very_long_tests)
root/io/perf/slowreading
- first create marker file and then run all combinations checking that time is not much differroot/io/perf/stl
tests with TLorenzVector - were not running with Makefileroot/io/perf/simple
tests - were not running with Makefileroot/io/perf/userdatasets
, all tests are failing and taking extremely long time, therefore useif(very_long_tests)