Skip to content

Conversation

@silverweed
Copy link
Contributor

This Pull request:

Adds basic tutorials for RFile both in C++ and python.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@hahnjo
Copy link
Member

hahnjo commented Nov 7, 2025

You will need to veto the tutorial if root7 is disabled, I guess

@silverweed
Copy link
Contributor Author

You will need to veto the tutorial if root7 is disabled, I guess

In the end we decided to build RFile regardless of that flag, so the test can be run even without (assuming that's what we want)

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! See minor comments

@hageboeck
Copy link
Member

Last thing from my side:
Maybe we could make the tutorial findable from here

This would entail putting it in the group tutorial_io, and maybe updating https://github.com/root-project/root/blob/master/tutorials/io/index.md

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Test Results

    22 files      22 suites   4d 0h 25m 57s ⏱️
 3 743 tests  3 743 ✅ 0 💤 0 ❌
80 395 runs  80 395 ✅ 0 💤 0 ❌

Results for commit 681bf71.

♻️ This comment has been updated with latest results.

@silverweed silverweed merged commit 59b9f9a into root-project:master Nov 10, 2025
29 of 30 checks passed
@silverweed silverweed deleted the rfile_tut branch November 10, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants