Skip to content

Conversation

@jblomer
Copy link
Contributor

@jblomer jblomer commented Nov 7, 2025

No description provided.

@jblomer jblomer requested review from couet and hahnjo November 7, 2025 22:23
@jblomer jblomer self-assigned this Nov 7, 2025
@jblomer jblomer requested a review from pcanal as a code owner November 7, 2025 22:23
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Test Results

    19 files      19 suites   3d 13h 22m 28s ⏱️
 3 738 tests  3 729 ✅ 0 💤 9 ❌
69 326 runs  69 317 ✅ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit bfa0828.

@hahnjo
Copy link
Member

hahnjo commented Nov 8, 2025

It seems this breaks the plugin mechanism for RRawFileDavix without runtime_cxxmodules, probably because ROOT cannot locate which library to load. Maybe we can get around it with #pragma link C++ class ROOT::Internal::RRawFileDavix-;, pretending to have a custom streamer?

@jblomer
Copy link
Contributor Author

jblomer commented Nov 8, 2025

It seems this breaks the plugin mechanism for RRawFileDavix without runtime_cxxmodules, probably because ROOT cannot locate which library to load. Maybe we can get around it with #pragma link C++ class ROOT::Internal::RRawFileDavix-;, pretending to have a custom streamer?

Strange. In the plug-in description, we specify the library. Also, why does it work then for the XRootD raw file that doesn't have a dictionary.

@hahnjo
Copy link
Member

hahnjo commented Nov 9, 2025

Also, why does it work then for the XRootD raw file that doesn't have a dictionary.

Hm, are we testing the plugin support for the root:// protocol? net/netxng/test/RRawFileNetXNG.cxx constructs RRawFileNetXNG directly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants