Fix interaction between RVecDS and Snapshot #20353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
requested review from
bellenot,
dpiparo and
martamaja10
as code owners
Test Results 21 files 21 suites 4d 1h 56m 59s ⏱️ Results for commit da72ac9. ♻️ This comment has been updated with latest results. |
hageboeck
approved these changes
Nov 10, 2025
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
Kind of LGTM, but two things could be touched up.
This commit updates the implementation of the column reader retrieval in RVecDS to use GetColumnReaders with type_info instead of the older version. This in turn allows Snapshot to request the correct column reader when reading a Numpy-based dataset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the implementation of the column reader retrieval in RVecDS to use GetColumnReaders with type_info instead of the older version. This in turn allows Snapshot to request the correct column reader when reading a Numpy-based dataset.
Fixes #20291