feat(plugins): deny access to .txt and .md files in plugin directories #1625
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
reviewed
Nov 15, 2025
|
|
||
| {% block plugin_docs_files -%} | ||
| # Block .txt and .md files in plugins and mu-plugins directories to prevent version disclosure | ||
| location ~* /plugins/.+\.(txt|md)$ { |
Member
There was a problem hiding this comment.
Should we anchor these to /app/plugins? Technically this would block any path containing plugins/foo.txt
Member
|
Following the same logic, I suggest we block |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin directories are often the first point of entry for attackers as they expose README.txt and CHANGELOG.md files to the public. This exposes version information which can be used to identify known vulnerabilities.
I don't think theres any upside in leaving these publicly accessible.