Skip to content

Conversation

glm4
Copy link
Collaborator

@glm4 glm4 commented Mar 9, 2022

Description:

Updates to the Fastfile and Github actions configuration files.

  • The build lanes will now run the signing and test suite first.

  • The setup_google_services and update_remote_google_services lanes are an attempt to let the CI/CD(github actions in this case) to configure all Firebase secrets before building the application. The downsides of this approach are:

    • Needs some tweaking to support multiple environments.
    • Needs to be replicated if more third party files are needed during the build phase but not added to the repository tree.
      PD: This is not really in the scope of this PR, more like an exploration for a solution to manage secrets and sensitive data.

Notes:

  • There is currently nothing forcing us to use Fastlane, considering the CI/CD platform recommended for all new projects is Bitrise.
    The only thing we would need to change is to run the test suite from the Github actions by using xcodebuild ... test rather than the fastlane run_test_suite lane.
    If we decide NOT TO go with the Fastlane approach because it introduces complexity to the workflow, the minimum requirements I considere this repository should met are:
  • The test suite must run for each PR and changes to master
  • The code coverage report to Code Climate must continue working.

Risk:

  • Low

Preview:

  • N/A

@glm4
Copy link
Collaborator Author

glm4 commented Oct 11, 2022

Closing this PR in favor of #194

@glm4 glm4 closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant