Skip to content

Remove deprecated parameter from pose_broadcaster #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

Related to #1614 which was released to rolling 4.24.0, which got not synced already -> we should not merge/release this before the sync

@christophfroehlich christophfroehlich added the hold Holding off merging this PR until some condition label May 17, 2025
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (0095ef1) to head (4d630fa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
+ Coverage   85.60%   85.65%   +0.05%     
==========================================
  Files         123      123              
  Lines       11873    11853      -20     
  Branches     1016     1012       -4     
==========================================
- Hits        10164    10153      -11     
+ Misses       1384     1380       -4     
+ Partials      325      320       -5     
Flag Coverage Δ
unittests 85.65% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pose_broadcaster/src/pose_broadcaster.cpp 87.17% <100.00%> (+5.15%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Amronos Amronos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't remove the member variables from the header file. Is that intentional?
Also, sorry for not getting to this earlier myself.

@christophfroehlich
Copy link
Contributor Author

No, I just missed that. Thanks for pointing out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Holding off merging this PR until some condition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants