Skip to content

Integrate tricycle_controller into steering_controller_library #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

Closes #850

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (dc53641) to head (7c9366c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...llers_library/src/steering_controllers_library.cpp 33.33% 7 Missing and 1 partial ⚠️
...ring_controllers_library/src/steering_odometry.cpp 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   85.69%   85.67%   -0.03%     
==========================================
  Files         123      123              
  Lines       11896    11928      +32     
  Branches     1015     1015              
==========================================
+ Hits        10194    10219      +25     
- Misses       1379     1387       +8     
+ Partials      323      322       -1     
Flag Coverage Δ
unittests 85.67% <76.19%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...steering_controllers_library/steering_odometry.hpp 100.00% <100.00%> (ø)
...ontrollers_library/test/test_steering_odometry.cpp 100.00% <100.00%> (ø)
tricycle_controller/src/tricycle_controller.cpp 66.80% <ø> (ø)
...ng_controller/src/tricycle_steering_controller.cpp 61.11% <ø> (ø)
...ring_controllers_library/src/steering_odometry.cpp 82.60% <86.66%> (-0.82%) ⬇️
...llers_library/src/steering_controllers_library.cpp 69.78% <33.33%> (-0.59%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Tricycle Controller a chainable controller tricycle_controller vs tricycle_steering_controller Refactoring getting the state/command handle
1 participant